github-actions[bot] commented on code in PR #67379:
URL: https://github.com/apache/doris/pull/67379#discussion_r3903473426
##########
be/src/storage/compaction/compaction.cpp:
##########
@@ -104,6 +104,23 @@ using std::vector;
namespace doris {
using namespace ErrorCode;
+bool should_cache_cloud_cumulative_compaction_output() {
+ return !config::enable_file_cache_write_index_file_only;
+}
+
+bool should_cache_cloud_base_compaction_output(int64_t
input_rowsets_cached_size,
+ int64_t
input_rowsets_total_size) {
+ if (config::enable_file_cache_write_index_file_only) {
Review Comment:
**[P3] Preserve the original single config snapshot**
`should_cache_compaction_output()` has already sampled
`enable_file_cache_write_index_file_only` before calling this helper. Because
the flag is runtime-mutable, a `false -> true -> false` update across the outer
read, this new inner read, and the later per-file read now leaves
`ctx.write_file_cache` latched `false`; before this extraction, the single
policy read preserved guaranteed retention for an otherwise eligible base
output once the flag returned to `false`. Adaptive caching may still retain the
files opportunistically, but when it is disabled or cannot admit the output
this newly loses the requested retention. Please pass the caller's single
snapshot into the helper so the extraction preserves the original
runtime-update behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
