bosswnx opened a new pull request, #67404:
URL: https://github.com/apache/doris/pull/67404
### What problem does this PR solve?
Issue Number: close #67403
Related PR: #66345 #66348 #64522 #66475
Problem Summary:
Two FE unit tests fail on current master because their assertions contradict
behavior that later PRs deliberately introduced:
-
`IcebergWritePlanProviderTest.planMergePreservesExplicitlyEmptyReadAcrossConcurrentFirstAppend`
asserts `baseSnapshotId == null` for an explicitly pinned empty read, but
#66348 intentionally changed this to keep the pinned `-1` as an OCC fence
(documented in `IcebergConnectorTransaction.applyBeginGuards`). The test from
#66345 was not updated, so it has been failing since #66348 landed.
- `PropertyAnalyzerTest.testAnalyzePartitionInvertedIndexFileStorageFormat`
expects the partition-level message *"only supports V2, V3 and SNII"* for `V1`,
but #64522 already throws the *"deprecated"* message inside
`analyzeInvertedIndexFileStorageFormat` before the partition-level check can
run, making the expected branch unreachable.
### What changed?
Test-only changes, no production code:
1. Update the Iceberg assertion to `assertEquals(Long.valueOf(-1L), ...)`
matching the intent documented in #66348, with a comment explaining the
semantics.
2. Accept either V1-rejection message in the PropertyAnalyzer assertion, so
the test stays valid regardless of which layer is chosen to reject V1; failure
output includes the actual message.
Both tests pass locally after the change: `IcebergWritePlanProviderTest`
79/79, `PropertyAnalyzerTest` 20/20.
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [x] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [x] Other reason <!-- test-only change, the changed tests are
themselves the coverage -->
- Behavior changed:
- [x] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [x] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
