Copilot commented on code in PR #67422:
URL: https://github.com/apache/doris/pull/67422#discussion_r3910517417
##########
fe/fe-core/src/main/java/org/apache/doris/master/Checkpoint.java:
##########
@@ -121,14 +121,6 @@ public synchronized void doCheckpoint() throws
CheckpointException {
if (imageVersion < checkPointVersion) {
LOG.info("Trigger checkpoint since last checkpoint journal id:
{} is less than "
+ "current finalized journal id: {}", imageVersion,
checkPointVersion);
- } else if (Config.isCloudMode() &&
Config.cloud_checkpoint_image_stale_threshold_seconds > 0
- && latestImageCreateTime > 0 &&
((System.currentTimeMillis() - latestImageCreateTime)
- >= Config.cloud_checkpoint_image_stale_threshold_seconds *
1000L)) {
- // No new finalized journals beyond the latest image.
- // But in cloud mode, we may still want to force a checkpoint
if the latest image file is expired.
- // This helps that image can keep the newer table version,
partition version, tablet stats.
- LOG.info("Trigger checkpoint in cloud mode because latest
image is expired. "
- + "latestImageSeq: {}, latestImageCreateTime: {}",
imageVersion, latestImageCreateTime);
} else {
return;
Review Comment:
Removing the stale-image checkpoint trigger makes
`cloud_checkpoint_image_stale_threshold_seconds` a no-op (no other references
remain in FE). If this config is still supported, consider preserving its
intent by rolling the edit log when the latest image is stale (so the next
checkpoint runs with a valid finalized journal id) rather than silently
ignoring the setting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
