github-actions[bot] commented on code in PR #67182:
URL: https://github.com/apache/doris/pull/67182#discussion_r3912417881
##########
fe/fe-connector/fe-connector-hive/src/main/java/org/apache/doris/connector/hive/HiveConnectorMetadata.java:
##########
@@ -577,8 +577,9 @@ public ConnectorTableSchema getTableSchema(
if (supportsHiveSampleAnalyze(tableInfo)) {
perTableCapabilities.add(ConnectorCapability.SUPPORTS_SAMPLE_ANALYZE);
}
- if (supportsHiveTopNLazyMaterialize(tableInfo)) {
+ if (supportsHiveOrcOrParquetScan(tableInfo)) {
perTableCapabilities.add(ConnectorCapability.SUPPORTS_TOPN_LAZY_MATERIALIZE);
+
perTableCapabilities.add(ConnectorCapability.SUPPORTS_STORAGE_PREDICATE_PRUNING);
Review Comment:
[P2] Include the native HoodieParquetInputFormatBase route
This marker shares Top-N's exact-class gate, but `HiveTableFormatDetector`
deliberately classifies `org.apache.hudi.hadoop.HoodieParquetInputFormatBase`
as plain Hive, and `HiveFileFormat`/`HiveScanPlanProvider` send it through the
native Parquet reader. Such a supported table therefore never gets
`SUPPORTS_STORAGE_PREDICATE_PRUNING`, so the post-pass skips it and cannot
expose these ranges to row-group min/max pruning. Please keep Top-N's narrower
whitelist separate, admit this native Parquet route for storage pruning, and
add it to the capability test. This is distinct from the existing Iceberg
capability thread.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
