Gabriel39 commented on code in PR #67166:
URL: https://github.com/apache/doris/pull/67166#discussion_r3912706267
##########
fe/fe-type/src/main/java/org/apache/doris/catalog/StructType.java:
##########
@@ -122,15 +123,15 @@ public boolean supportSubType(Type subType) {
public void addField(StructField field) {
field.setPosition(fields.size());
fields.add(field);
- fieldMap.put(field.getName().toLowerCase(), field);
+ fieldMap.put(field.getName().toLowerCase(Locale.ROOT), field);
}
public ArrayList<StructField> getFields() {
return fields;
}
public StructField getField(String fieldName) {
- return fieldMap.get(fieldName.toLowerCase());
+ return fieldMap.get(fieldName.toLowerCase(Locale.ROOT));
Review Comment:
Fixed in d6f98ebafd. Exact ROOT-key lookup remains the primary path. A
broader compatibility lookup is now used only after an exact miss and only for
replayed fields whose pre-change metadata has no originalName; that legacy
marker is preserved through Catalog-to-Nereids conversion and back. Newly
created ROOT-distinct names remain separate. Added a Turkish pre-ROOT JSON
replay test plus a guard for current dotless-i fields. The PR description now
defines the supported new-FE-reading-old-Master rolling-upgrade direction and
the metadata-format boundary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
