damokelis commented on PR #66790: URL: https://github.com/apache/doris/pull/66790#issuecomment-5516087521
Rebased onto current master (`f054492cbb9`). The only conflict was in `PaimonConnector.java`, from #66633 ([refactor](catalog) Unify external metadata cache framework) collapsing the three connector-owned caches into `metaCache` — resolved by keeping the new `metaCache.invalidateTable/Database/Catalog()` calls and re-attaching the paimon-SDK-side `CachingCatalog` eviction on top of them. I have also split four self-contained fixes out of this PR so they can be reviewed independently of the Paimon 2.0 upgrade. None of them depend on any Paimon 2.0 code, and each fixes a defect that is present on master today: | PR | Scope | Size | | --- | --- | --- | | #67459 | `[fix](be)` duplicate default argument on the `clear_blocks` forward declaration added by #66400 — a hard `-Werror` failure under Unity Build | +1/-1 | | #67460 | `[fix](filesystem)` accept the dotted `s3.path.style.access` alias, the spelling 42 existing regression catalogs already use | +3/-2 | | #67461 | `[fix](build)` `fe-connector-hms-hive-shade` clean build fails with *main artifact does not exist* | +9 | | #67462 | `[fix](nereids)` gate `IcebergRowLevelDmlTransform` on catalog identity, so `RowLevelDmlRegistry` stays correct once a second connector declares row-level capabilities | +17/-1 | Those four are still included here as well, so this PR remains self-contained; whichever land first, I will rebase this one on top and drop the duplicates. On scope: this PR is large because Paimon 2.0 is a breaking SDK upgrade — the connector runtime bump, the write path, and the read path cannot land separately without leaving the build broken in between. If it would help review, I am happy to split the remainder further along whatever seam you prefer (e.g. read/upgrade first, then transactional writes, then schema evolution and row-level DML). Guidance on the preferred sequencing would be very welcome. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
