Gabriel39 commented on PR #67166: URL: https://github.com/apache/doris/pull/67166#issuecomment-5521529060
@924060929 Thanks for the compatibility review. I checked all four points against the current PR head: 1. The Catalog `StructType.getField` compatibility fallback was already present. However, the review exposed a real edge case: a pre-ROOT image can contain two legacy runtime names that both match one selector under broad Unicode case folding. Commit 458e4651d9 fixes this by accepting a legacy fallback only when it is unique; exact persisted runtime spellings still work, and ambiguous selectors are rejected instead of returning the wrong sibling. I did not add `readObject`: these types are replayed through Gson, and rebuilding `fieldMap` cannot recover the original locale or external spelling that old images never persisted. 2. `StructElement` no longer exists on current master; it was merged into `ElementAt`. Both `element_at` and the `struct_element` alias therefore use the same `StructType.getField` path, so no separate fix is needed. 3. `IcebergScanNode` no longer exists on current master. Identity partition columns are obtained through `IcebergPartitionUtils.getIdentityPartitionColumns`, which intentionally preserves source-column case and already has focused coverage, so changing partition-key case handling is outside this PR. 4. `StructType.addField` already uses `toLowerCase(Locale.ROOT)` on the current PR head, so no additional change is needed there. I also fixed the separate computed-base dereference gap in 458e4651d9 and added regression coverage for both valid issues. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
