Copilot commented on code in PR #67494: URL: https://github.com/apache/doris/pull/67494#discussion_r3924048627
########## be/src/cloud/config.cpp: ########## @@ -88,7 +88,8 @@ DEFINE_mBool(enable_sync_tablet_delete_bitmap_by_cache, "true"); DEFINE_mInt32(delete_bitmap_store_write_version, "1"); DEFINE_mInt32(delete_bitmap_store_read_version, "1"); DEFINE_mBool(enable_delete_bitmap_store_v2_check_correctness, "false"); -DEFINE_mInt64(delete_bitmap_store_v2_max_bytes_in_fdb, "1024"); // TODO change default value +// same as split_size of blob_put +DEFINE_mInt64(delete_bitmap_store_v2_max_bytes_in_fdb, "90000"); Review Comment: The new default value is a magic number and the comment is a bit too vague for future maintainers. Since this threshold is intended to align with `blob_put` chunking and also stay under FoundationDB per-value size limits, consider spelling out the unit (bytes/KB) and why 90,000 was chosen (headroom below ~100KB). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
