jacktengg commented on code in PR #67492:
URL: https://github.com/apache/doris/pull/67492#discussion_r3925702112
##########
be/src/exprs/function/cast/cast_to_date_or_datetime_impl.hpp:
##########
@@ -701,7 +701,6 @@ inline bool
CastToDateOrDatetime::from_string_strict_mode(const StringRef& str,
res.template
unchecked_set_time_unit<TimeUnit::SECOND>((uint32_t)local.second());
}
- static_cast<void>(skip_any_whitespace(ptr, end));
Review Comment:
fixed
##########
be/src/exprs/function/cast/cast_to_datetimev2_impl.hpp:
##########
@@ -710,7 +710,6 @@ inline bool
CastToDatetimeV2::from_string_strict_mode_internal(
}
SET_PARAMS_RET_FALSE_IFN(res.year() <= 9999, "datetime year {} out of
range [0, 9999]",
res.year());
- static_cast<void>(skip_any_whitespace(ptr, end));
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]