xy720 opened a new pull request, #67532:
URL: https://github.com/apache/doris/pull/67532
`getPrettyNereidsOptimizeTime` computes the elapsed time as `optimizeFinish
- preRewriteByMvFinish`,
But `preRewriteByMvFinish` is only set at the tail of
`preMaterializedViewRewrite`, which early-exits whenever pre-rewrite is not
needed.
The start marker stays at -1, `getPrettyTime` sees -1 and returns "N/A" —
even though CBO did run and `optimizeFinish` is set.
This misleads users on any query that skips MV pre-rewrite: 1.MV refresh,
2.INSERT, large joins using DpHyper,
3.Sessions with `enable_materialized_view_rewrite=false`, 4.Queries that
don't touch any MV at all
Example:
an MV refresh with
`Rewrite Time: 4ms`,
`Translate Time:239ms`
still prints `Optimize Time: N/A`, misleading anyone reading the profile
into thinking CBO was skipped.
Fall back the start marker through earlier phase finish times
(`preRewriteByMv -> collectTablePartition -> rewrite`) so the elapsed time is
shown whenever the upstream phase actually finished.
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [x] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [x] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
