lets-order-some-fries commented on PR #67238: URL: https://github.com/apache/doris/pull/67238#issuecomment-5548507710
@morrySnow when you have a moment — this one needs a committer trigger to move, and I want to make sure it isn't just sitting on a stale signal. The `/review` findings are addressed in `66e0ff14` (pushed Aug 31): signature matching summed the timezone preference across arguments, so a zoned literal paired with a zone-less one cancelled to 0 and tied DATETIMEV2. It now tracks the two independently, so an explicit zone anywhere in the call decides instant semantics and cannot be cancelled out. Two things are stale rather than failing: - **`run buildall` last ran against `f5c40e8a`**, the pre-fix commit. `66e0ff14` has never been built. - **`code-review` still reads "Trigger /review to start automated review for `66e0ff14`"**, so the visible `CHANGES_REQUESTED` is the verdict on the older commit. I posted `/review` myself on Sep 2 and it did not start the job — the trigger looks committer-only. So a re-run of both would either clear it or give you something real to look at. No rush on my open question about widening `DateTimeChecker.timeZone()` for compact `-0700` offsets — that one is genuinely your call, and I'm happy either way (here, or a follow-up). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
