Gabriel39 commented on code in PR #67545: URL: https://github.com/apache/doris/pull/67545#discussion_r3942843746
########## fe/fe-connector/fe-connector-metastore-spi/src/main/java/org/apache/doris/connector/metastore/spi/AbstractDlfMetaStoreProperties.java: ########## @@ -0,0 +1,123 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.doris.connector.metastore.spi; + +import org.apache.doris.connector.metastore.DlfMetaStoreProperties; +import org.apache.doris.foundation.property.ConnectorProperty; + +import org.apache.commons.lang3.BooleanUtils; +import org.apache.commons.lang3.StringUtils; + +import java.util.LinkedHashMap; +import java.util.Map; + +/** Shared Aliyun DLF property binding and neutral catalog configuration. */ +public abstract class AbstractDlfMetaStoreProperties extends AbstractMetaStoreProperties + implements DlfMetaStoreProperties { + + @ConnectorProperty(names = {"dlf.access_key", "dlf.catalog.accessKeyId"}, required = false, sensitive = true, + description = "DLF access key id.") + private String accessKey = ""; + + @ConnectorProperty(names = {"dlf.secret_key", "dlf.catalog.accessKeySecret"}, required = false, sensitive = true, Review Comment: Aligned the DLF AK/SK/token aliases across the metastore holder, native OSS, and OSS-HDFS binders. Added holder and storage-binding tests, plus regression coverage that verifies both legacy and canonical credentials are masked in SHOW CREATE CATALOG. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
