yiguolei commented on code in PR #67019:
URL: https://github.com/apache/doris/pull/67019#discussion_r3946417545
##########
be/src/storage/index/zone_map/zone_map_index.cpp:
##########
@@ -206,11 +206,18 @@ void
TypedZoneMapIndexWriter<Type>::modify_index_before_flush(
// slightly larger than any real string that shares the same 512-byte
prefix, ensuring no false negatives —
// the zone map will never incorrectly skip a page that contains matching
data.
//
- // In UTF8 encoding, here do not appear 0xff in last byte
if constexpr (Type == TYPE_CHAR || Type == TYPE_VARCHAR || Type ==
TYPE_STRING) {
Review Comment:
这个代码，单独提一个PR 吧，并且补充一下单测
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
