CalvinKirs commented on PR #67186:
URL: https://github.com/apache/doris/pull/67186#issuecomment-5567825281
<!-- doris-repo-review:v1:begin -->
### Local pipeline review — ✅ PASS
```yaml
schema: doris-repo-review/v1
status: PASS
pr: apache/doris#67186
commit: cd5db406e18cb5a7808e6c8b393d82fb82684d74
base: eea19b3f3cfef9e1bbbd559f9ea42954d8891e0f
reviewed_at: 2026-09-07T16:39+08:00
reviewer: CalvinKirs
model: gpt-5.6-sol
effort: unknown
findings: {blocker: 0, major: 0, minor: 2, nit: 0}
rounds: 1
converged: true
```
**Notes for maintainers**
-
`fe/fe-core/src/main/java/org/apache/doris/datasource/scan/PluginDrivenScanNode.java:1998`
— Register async scan cleanup before pre-dispatch checked-error exits so Arrow
Flight statement-scope resources are closed (F-01, Minor).
-
`fe/fe-core/src/main/java/org/apache/doris/datasource/scan/PluginDrivenScanNode.java:2058`
— Publish the shared batch failure once and make `taskFinished()`
unconditional to preserve final profile draining (F-02, Minor).
-
`fe/fe-connector/fe-connector-hms/src/main/java/org/apache/doris/connector/hms/HmsPartitionBatchExecutor.java:97`
— The original reviewer line-92 scope reduction remains intact: only finite,
size-related fallback is present.
-
`fe/fe-core/src/main/java/org/apache/doris/datasource/scan/PluginDrivenScanNode.java:1607`
— Prune-to-zero already goes through the dedicated profile finalizer and needs
no further change.
<sub>Reviewed locally with the `doris-repo-review` pipeline (a local port of
`.github/workflows/code-review-runner.yml`). This is not a CI status
check.</sub>
<!-- doris-repo-review:v1:end -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
