CalvinKirs commented on PR #67520: URL: https://github.com/apache/doris/pull/67520#issuecomment-5567829425
### Local agent review result — reviewed local commit, not current PR head Completed a local review using the official `apache/doris-skills` workflow at `8c13ef3c96124232c6679b6d8764c33f937cf660`, with a lead and two coverage reviewers, all running `gpt-6-astra` / `xhigh`. - **Reviewed commit:** `291281c122d03b1d51bc08f85a5708e784501a88` (local, not yet pushed). - **Remote PR head at publication:** `32d01e5df19180f8b01c0f9e1112d5d42b02bab3`. - **Review base:** `eea19b3f3cfef9e1bbbd559f9ea42954d8891e0f`. - **Local verdict:** APPROVE; 0 Blocker / 0 Major / 0 Minor / 0 Nit. All 24 changed files covered; converged in round 1. The original document verifier passed. The local commit addresses the previously identified zero-parameter prepared-forwarding issue by preserving the empty execute payload, exercises the actual plain Statement entry, and corrects the two SQL-result assertions identified in the previous review. The updated regression disables JDBC preparation fallback and prepares on a follower before enabling forwarding. **Limits:** These fixes and this verdict apply to the reviewed local commit, not the current remote PR head. This comment is not an exact-head PASS receipt or a human Apache approval. No build or tests were run during this review. Checkstyle had passed for the local fix, but the new unit/regression tests and strengthened JDBC probe have not been executed; the historical JDBC successes do not prove the newly covered forwarding path. Follower coverage is explicitly skipped when no live non-master FE exists. A separate, pre-existing parameter-type caching issue in repeated parameterized prepared forwarding remains unresolved and is outside this zero-parameter fix. It is not counted as a newly introduced finding. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
