deardeng opened a new pull request, #67640:
URL: https://github.com/apache/doris/pull/67640
Problem Summary: Background checkpoint and HTTP /dump can write images
concurrently. A static MetaWriter shares a mutable delegate between those
writes, allowing one image's module indices to be recorded in another image.
Checkpoint also renames the new file before reading it back. Stopping FE during
that validation window can leave a corrupt image as the newest startup
candidate and prevent restart.
Give each write its own MetaWriter, validate the unpublished image.ckpt in a
fresh checkpoint Env, and publish it only after validation succeeds. Failed
validation cleans the temporary file and preserves the previous published
image. Add deterministic concurrent writer and checkpoint publication unit
tests.
### Release note
Prevent concurrent checkpoint and metadata dump operations from sharing
image indices, and keep unvalidated checkpoints out of FE startup image
selection.
### Check List (For Author)
- Test: Unit tests added but not run; compilation and test execution
deferred to the user as requested. Checkstyle 9.3 with repository configuration
and git diff --check passed.
- Behavior changed: Yes. Checkpoint images become visible only after
successful read-back validation.
- Does this need documentation: No
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
