gavinchou commented on code in PR #67652:
URL: https://github.com/apache/doris/pull/67652#discussion_r3956175840
##########
be/src/cloud/cloud_tablet.cpp:
##########
@@ -1588,11 +1592,12 @@ Status CloudTablet::sync_meta() {
_tablet_meta->set_time_series_compaction_level_threshold(
new_time_series_compaction_level_threshold);
}
- if (_tablet_meta->tablet_schema()->disable_auto_compaction() !=
- new_disable_auto_compaction) {
- _tablet_meta->mutable_tablet_schema()->set_disable_auto_compaction(
- new_disable_auto_compaction);
- }
+ // `disable_auto_compaction` lives in TabletSchema, which is shared
across tablets via
+ // TabletSchemaCache (keyed by the serialized schema). Mutating the
shared schema in place
+ // pollutes the cache entry of the current schema: a later tablet meta
fetched from Meta
+ // Service with the original schema resolves to the same polluted
object, so the flag can
+ // never be switched back. Keep the effective value on the tablet
itself instead.
+ set_disable_auto_compaction(new_disable_auto_compaction);
Review Comment:
if it is the schema cache issue, solve the issue it-self
this workaround may leave another potential issue that changes the
tablet/meta/schema
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
