yy782 commented on PR #65790: URL: https://github.com/apache/doris/pull/65790#issuecomment-5601913774
Thanks for the review. A few questions before I add tests: 1. For the circle boundary comment: since the contains matrix won't be extended, cases like `ST_Within(ST_Point(1,0), ST_Circle(0,0,ST_Distance_Sphere(0,0,1,0)))` (point exactly on the boundary) will keep returning 1. Is it still necessary to add such a test case? 2. Should I add a `check_function_all_arg_comb` BE-UT for ST_Within only (per the guide), or keep consistent with the sibling geo functions for now? 3. Are the current regression cases sufficient, or should I add at least one non-constant SQL case (e.g. in the existing table-driven section)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
