924060929 commented on PR #67725: URL: https://github.com/apache/doris/pull/67725#issuecomment-5614798499
For the next revision, I suggest running the repository review workflow locally before requesting another remote `/review`: https://github.com/apache/doris-skills/blob/main/skills/doris-repo-review/SKILL.md A practical iteration loop is: ```text push a candidate commit to the PR branch -> run /doris-repo-review against this PR and exact pushed head -> read the generated English/Chinese reports and resolve every actionable finding -> push the fixes as a new head -> rerun /doris-repo-review -> repeat until the review converges without new actionable findings -> run the required local build and focused tests -> only then request the remote /review again ``` Two details are important: 1. `doris-repo-review` reviews the exact PR head from GitHub. Local commits that are ahead of the PR are explicitly not part of its review, so each candidate head must be pushed before that review round. Please use a clean dedicated checkout/worktree because its alignment step checks out the PR head and refuses modified tracked files. 2. The skill is intentionally read-only: it does not build, run tests, or edit source. Its converged result therefore does not replace compilation and tests. Please run the FE build and relevant unit/regression tests separately before pushing the final revision or asking CI/reviewers to check it. This local loop should catch cross-module call-chain, lifecycle, compatibility, and test-coverage problems before consuming another remote CI/reviewer round. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
