924060929 commented on code in PR #67177:
URL: https://github.com/apache/doris/pull/67177#discussion_r3978540146
##########
be/src/exec/pipeline/pipeline_fragment_context.cpp:
##########
@@ -1073,8 +1084,8 @@ Status PipelineFragmentContext::_add_local_exchange_impl(
: 0);
break;
case TLocalPartitionType::PASS_TO_ONE:
- if (_runtime_state->enable_share_hash_table_for_broadcast_join()) {
- // If shared hash table is enabled for BJ, hash table will be
built by only one task
+ if (_runtime_state->be_exec_version() >=
SUPPORT_UNCONDITIONAL_PASS_TO_ONE_VERSION ||
Review Comment:
Fixed in 09dff80c8b6. The BE-native hash-join build requirement now directly
returns PASS_TO_ONE when the broadcast hash table is shared and BROADCAST when
it is private. Both local-exchange factories then honor the enum literally, so
there is no longer a PASS_TO_ONE-to-BROADCAST reinterpretation.
HashJoinBuildSinkTest covers NOOP for a parallel build child and both
shared/private serial-build outcomes; the private-build regression uses INNER
JOIN plus COUNT of the build side.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
