CalvinKirs commented on PR #67726:
URL: https://github.com/apache/doris/pull/67726#issuecomment-5629238907
<!-- doris-repo-review:v1:begin -->
### Local pipeline review — ✅ PASS
```yaml
schema: doris-repo-review/v1
status: PASS
pr: apache/doris#67726
commit: de093b21cb45ad8e33b524542bc3eb0487dcd03e
base: 60042611fea1b18576470a7e3c49e14cd11243a4
reviewed_at: 2026-09-11T12:00+08:00
reviewer: CalvinKirs
model: gpt-6-astra
effort: high
findings: {blocker: 0, major: 0, minor: 0, nit: 0}
rounds: 1
converged: true
```
**Notes for maintainers**
- The final repaired commit was verified by two module-review agents and an
independent risk crosscheck, with coverage of all 83 changed files. Earlier
findings were fixed; the earlier three-round run was not retroactively marked
converged.
- Validation on this commit: 402 targeted FE/connector tests passed (0
failures, errors or skips); FE/plugin packaging and Checkstyle passed.
-
`fe/fe-connector/fe-connector-iceberg/src/main/java/org/apache/doris/connector/iceberg/IcebergTableCache.java:277-280`
— incomplete estimation still rejects retention while preserving successful
metadata JSON for the borrower; an old-code failing/new-code passing test
exercises real SDK manifest-length resolution.
- No BE/C++ build, fresh deployed-cluster regression or mixed-version run
was performed in this repair. The focused manifest test uses an in-memory
input, not a complete external-storage scan.
- Estimates are approximate and budgets do not cap transient query memory or
total FE heap. Supported BE-first compatibility was reviewed; reverse upgrade
order is not claimed supported.
<sub>Reviewed locally with the `doris-repo-review` pipeline (a local port of
`.github/workflows/code-review-runner.yml`). This is not a CI status
check.</sub>
<!-- doris-repo-review:v1:end -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
