github-actions[bot] commented on code in PR #67856:
URL: https://github.com/apache/doris/pull/67856#discussion_r3987032539


##########
fe/fe-core/src/main/java/org/apache/doris/common/proc/IndexInfoProcDir.java:
##########
@@ -132,6 +133,8 @@ public ProcNodeInterface lookup(String idxIdStr) throws 
AnalysisException {
                                     && 
SessionVariable.enableDescribeExtendVariantColumn()) {
                     return new RemoteIndexSchemaProcDir(table, schema, 
bfColumns);
                 }
+            } else if (table instanceof IcebergExternalTable) {

Review Comment:
   [P1] Keep SHOW COLUMNS on the declared-nullability path
   
   This special case fixes the proc-backed `DESC`, but `ShowColumnsCommand` 
still reads `table.getBaseSchema()` (and its `WHERE` form goes through 
`information_schema.columns`, whose FE producer also reads 
`getBaseSchemaOrEmpty()`). Iceberg's scan schema intentionally marks every 
field nullable, so a required field now reports `No` in `DESC` and `NOT NULL` 
in `SHOW CREATE TABLE`, yet `YES` in `SHOW [FULL] COLUMNS` / 
`information_schema.columns`. Please route those metadata-only paths through an 
independent display schema too, without changing scan columns, and cover both 
direct and filtered forms.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to