github-actions[bot] commented on code in PR #67857:
URL: https://github.com/apache/doris/pull/67857#discussion_r3987058954
##########
docker/compilation/Dockerfile:
##########
@@ -120,7 +138,9 @@ ENV JAVA_HOME="/usr/lib/jvm/jdk-17.0.2/" \
MAVEN_HOME="/usr/share/maven" \
REPOSITORY_URL="https://doris-thirdparty-repo.bj.bcebos.com/thirdparty"; \
DEFAULT_DIR="/var/local" \
-
PATH="/usr/local/bin:/var/local/ldb-toolchain/bin/:/var/local/thirdparty/installed/bin/:/usr/lib/jvm/jdk-17.0.2/bin/:$PATH"
\
+ CARGO_HOME="/opt/cargo" \
+ RUSTUP_HOME="/opt/rustup" \
+
PATH="/opt/cargo/bin:/usr/local/bin:/var/local/ldb-toolchain/bin/:/var/local/thirdparty/installed/bin/:/usr/lib/jvm/jdk-17.0.2/bin/:$PATH"
\
Review Comment:
[P2] Persist the Rust linker policy in the final image
The `/usr/bin/gcc` selection at line 125 is scoped to that single builder
`RUN`. `FROM scratch` does not inherit the builder's environment metadata, and
this final `ENV` restores Cargo/Rustup paths without restoring
`CARGO_TARGET_X86_64_UNKNOWN_LINUX_GNU_LINKER`. A user who runs a clean
`thirdparty/build-thirdparty.sh lance_c` (or full thirdparty rebuild) in the
published compilation image therefore finds Cargo but falls back to the LDB
`cc`, recreating the documented GLIBC_2.18 host-helper failure on this glibc
2.17 image. Please persist the target linker here or provide an equivalent
durable Cargo config, and smoke-test an actual final-image rebuild rather than
only `cargo --version`.
##########
docker/compilation/Dockerfile:
##########
@@ -103,9 +109,21 @@ RUN wget
https://doris-community-bj-1308700295.cos.ap-beijing.myqcloud.com/tools
RUN rm -f /etc/profile.d/ccache.* \
&& cp /etc/pki/tls/certs/ca-bundle.crt /etc/ssl/certs/ca-certificates.crt
+# Install the Rust toolchain required by Lance-C.
Review Comment:
[P1] Fix the other maintained compilation images
Both `docker/compilation/Dockerfile.gcc10` and
`docker/compilation/arm/Dockerfile` still invoke
`thirdparty/build-thirdparty.sh` without a package subset, so they reach the
default `lance_c` entry and exit at `build_lance_c`'s `command -v cargo` check
because neither image provisions Rust. The GCC10 recipe is also `FROM centos:7`
but reaches `yum makecache` before applying any vault/EPEL rewrite, so it
retains this PR's earlier repository failure too. These sibling recipes were
updated alongside this one in recent build-environment changes, so please apply
the Rust/repository/linker prerequisites to every retained variant (with the
correct architecture target), or explicitly retire unsupported recipes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
