HappenLee commented on code in PR #67805:
URL: https://github.com/apache/doris/pull/67805#discussion_r3988042805
##########
be/src/exprs/aggregate/aggregate_function_window_funnel_v2.h:
##########
@@ -184,9 +184,16 @@ struct WindowFunnelStateV2 {
}
if (events_list.empty()) {
+ window = other.window;
Review Comment:
Fixed in 21892a505bf8789c96f101531c7cfb6c9d55364c.
An initialized all-false V2 state now retains its window/mode. Merge
validates configured parameters before either empty-payload fast path, in both
operand orders. Reset clears initialization and the stored parameter fields;
truly fresh states remain identities.
Serialization keeps the existing field layout. Configured-empty states use
tag 2 in the sorted varint, which legacy readers already interpret as sorted.
New readers recover older 0/1 states from their stored configuration/payload.
Tests cover legacy header decoding, legacy framing of new states, and newly
configured values that collide with the fresh-state sentinels.
Validation: the original binary fails the new all-false mismatch regression
because no exception is raised. The final BE ASAN build, 58 related unit tests,
and all three regression suites (test_agg_state_parameters, window_funnel,
window_funnel_v2) pass. Coverage includes eventless/contributing and
eventless/eventless pairs, both merge/union orders, fresh adoption, reset
serialization, compatible states, and the default alias. clang-format 16,
header hygiene and whitespace checks pass. clang-tidy reports no diagnostics on
changed lines; existing diagnostics still prevent a clean full check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
