This is an automated email from the ASF dual-hosted git repository.
morningman pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 7d3abdeca52 [fix](fe) Migrate VersionHelperTest to JUnit 5 (#67865)
7d3abdeca52 is described below
commit 7d3abdeca52a60006d5fe1a46d1ea153189da5a7
Author: meiyi <[email protected]>
AuthorDate: Fri Sep 11 17:59:27 2026 +0800
[fix](fe) Migrate VersionHelperTest to JUnit 5 (#67865)
Problem Summary: VersionHelperTest imports JUnit 4 Test and Assert,
causing FE Checkstyle validation to fail under banJUnit4.
---
.../test/java/org/apache/doris/cloud/rpc/VersionHelperTest.java | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git
a/fe/fe-core/src/test/java/org/apache/doris/cloud/rpc/VersionHelperTest.java
b/fe/fe-core/src/test/java/org/apache/doris/cloud/rpc/VersionHelperTest.java
index ffdb81a988f..2b0e8653458 100644
--- a/fe/fe-core/src/test/java/org/apache/doris/cloud/rpc/VersionHelperTest.java
+++ b/fe/fe-core/src/test/java/org/apache/doris/cloud/rpc/VersionHelperTest.java
@@ -20,8 +20,8 @@ package org.apache.doris.cloud.rpc;
import org.apache.doris.cloud.proto.Cloud;
import org.apache.doris.rpc.RpcException;
-import org.junit.Assert;
-import org.junit.Test;
+import org.junit.jupiter.api.Assertions;
+import org.junit.jupiter.api.Test;
import org.mockito.MockedStatic;
import org.mockito.Mockito;
@@ -42,7 +42,7 @@ public class VersionHelperTest {
try (MockedStatic<MetaServiceProxy> mockedProxy =
Mockito.mockStatic(MetaServiceProxy.class)) {
mockedProxy.when(MetaServiceProxy::getInstance).thenReturn(proxy);
- Assert.assertThrows(RpcException.class, () ->
VersionHelper.getVisibleVersion(request, 3));
+ Assertions.assertThrows(RpcException.class, () ->
VersionHelper.getVisibleVersion(request, 3));
}
Mockito.verify(proxy,
Mockito.times(3)).getVisibleVersionAsync(request);
@@ -62,7 +62,7 @@ public class VersionHelperTest {
try (MockedStatic<MetaServiceProxy> mockedProxy =
Mockito.mockStatic(MetaServiceProxy.class)) {
mockedProxy.when(MetaServiceProxy::getInstance).thenReturn(proxy);
- Assert.assertSame(notFoundResponse,
VersionHelper.getVisibleVersion(request, 3));
+ Assertions.assertSame(notFoundResponse,
VersionHelper.getVisibleVersion(request, 3));
}
Mockito.verify(proxy).getVisibleVersionAsync(request);
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
