morningman commented on PR #67883:
URL: https://github.com/apache/doris/pull/67883#issuecomment-5641333233
<!-- doris-repo-review:v1:begin -->
### Local pipeline review — ✅ PASS
```yaml
schema: doris-repo-review/v1
status: PASS
pr: apache/doris#67883
commit: ddf172ac09853c249a089142c481c3a71ac2493c
base: c017770d3cbc0ee1aa68529a31a35960fa2d4328
reviewed_at: 2026-09-12T06:26+08:00
reviewer: morningman
model: claude-opus-5[1m]
effort: max
findings: {blocker: 0, major: 0, minor: 2, nit: 4}
rounds: 1
converged: true
```
**Notes for maintainers**
-
`fe/fe-core/src/main/java/org/apache/doris/mysql/protocol/MysqlProtocolAdapter.java:128-137`
— pre-existing, preserved verbatim by the move: on a follower with
`CLIENT_MULTI_STATEMENTS`, a non-last forwarded statement the master rejects
has its ERR packet flushed by the intermediate `finishCommand`, then
`processOnce` runs `finishCommand` again on the same executor and emits a
zero-length packet (the master packet `ByteBuffer` is already consumed). Worth
ending the request on a forwarded failure in the follow-up that next touches
`finishStatement`.
-
`fe/fe-core/src/main/java/org/apache/doris/arrowflight/protocol/FlightProtocolAdapter.java:343-347`
— the folded-in `getExecTimeoutS()` wait bound has no test that fails if it is
reverted: the only lock-timeout test runs with no executor on the session,
where it collapses to `getQueryTimeoutS()`. Same for the
`FlightRuntimeException` pass-through in `DorisFlightSqlProducer`.
-
`fe/fe-core/src/main/java/org/apache/doris/mysql/protocol/MysqlResultSender.java:55-57`
— "encoded with this session's negotiated capabilities" is byte-neutral for
every client Doris authenticates (only the EOF writer reads the capability, via
`isProtocol41`); the observable change for the IVM dry run is the Connector/J
cursor-probe terminator now following the caller's own cursor request. Consider
rewording here and in the PR body.
- `EXPLAIN` / `REPLAY` / `EXPLAIN PLAN PROCESS` under `COM_STMT_EXECUTE` now
return binary rows where the base wrote text rows into a binary-protocol
response — a correctness improvement the PR body does not list.
- Every moved MySQL encoding body was diffed method by method against the
base and is identical modulo accessor renames; the multi-statement fold and the
`returnResultFromLocal` transitions were traced base vs head and are equivalent
except for the declared behavior change #3, whose bytes no Flight session
consumes.
<sub>Reviewed locally with the `doris-repo-review` pipeline. Repository
policy may accept this receipt for the matching commit; it is not a human
Apache approval.</sub>
<!-- doris-repo-review:v1:end -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
