morningman commented on PR #66729:
URL: https://github.com/apache/doris/pull/66729#issuecomment-5643726393
<!-- doris-repo-review:v1:begin -->
### Local pipeline review — ✅ PASS
```yaml
schema: doris-repo-review/v1
status: PASS
pr: apache/doris#66729
commit: 9609ff630c8667696139c7689119de76acf5ac90
base: 859a19c3a54b3a0a09bb198f9a9f2c5c4c1cdc47
reviewed_at: 2026-09-12T13:20+08:00
reviewer: morningman
model: claude-opus-5[1m]
effort: max
findings: {blocker: 0, major: 0, minor: 1, nit: 7}
rounds: 1
converged: true
```
**Notes for maintainers**
-
`fe/be-java-extensions/jni-spi/src/test/java/org/apache/doris/jni/spi/vec/VectorTableTimestampNsTest.java:45`
— deleting `java-common`'s `JniScannerTest` ported only master's two
TIMESTAMP_NS cases; `testUnencodedStructFieldNamesRemainLowerCase`, the sole
unit test of the legacy-grammar STRUCT-key lowercasing
(`ColumnType.java:456-459`), has no counterpart at this head (the one Minor).
- Rebase onto `859a19c3` verified by content, not by hash: over the 44 files
both master and this PR modify, zero master-added lines are missing at HEAD;
the #66761 (TIMESTAMP_NS) and #67046 (UDF cache by id) ports were checked
symbol by symbol; CI is green on this exact head for COMPILE, BE/FE/Cloud UT
and every regression line, and the FE UT log shows every migrated test class
running with its full `@Test` count.
-
`fe/fe-connector/fe-connector-hudi/src/main/java/org/apache/doris/connector/hudi/HudiConnector.java:399`
— "A Kerberos catalog never reaches here" became stale when master #66890
split the HMS and storage identities: an HMS-Kerberos catalog with simple
storage now does reach `fileSystemScope()` (behaviour is correct; the sentence
is not).
- `fe/be-java-extensions/pom.xml:53` — the aggregator's reason for banning
per-module JUnit ("fails the Dependency License Review") is no longer true at
this base: master #67396 exempts both JUnit purls in `third_party_review.yml`;
keep the rule, fix the reason.
- Of the 33 findings inherited from the `e9746fc`/`11ff064` reviews,
`e9746fc F-08` (no terminal flag on `IcebergConnector`) is fixed at this head
by master #66914; the other 32 stand unchanged, re-anchored in the review
documents.
<sub>Reviewed locally with the `doris-repo-review` pipeline. Repository
policy may accept this receipt for the matching commit; it is not a human
Apache approval.</sub>
<!-- doris-repo-review:v1:end -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
