HappenLee commented on PR #67805: URL: https://github.com/apache/doris/pull/67805#issuecomment-5650777936
/review Please re-review the current head bf483fc348a1ea28c511e24fc1719f4162e71ad1. Both findings from the latest review have been addressed and their threads resolved. The updated contract is that percentile_approx_array returns [] with no retained samples and uses the existing fresh-state serialized encoding; only two contributing states compare quantiles and compression. Please check direct/serialized merges, operand and association order, later contributors, nullable wrappers and _state/_combine/_merge/_union paths, together with the restored compact collect marker and negative-limit/reset behavior. Also retain coverage of the FE AggState nullable-layout and explicit-cast changes. The current PR description and latest replies supersede the earlier all-empty shape-preservation policy. Historical trial-state compatibility, linear_histogram and the multi-distinct group_concat wrapper remain outside this PR's scope. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
