Gabriel39 commented on PR #67784: URL: https://github.com/apache/doris/pull/67784#issuecomment-5651223575
Review and CI follow-up: - Preserve the existing CDC-to-OLAP storage contract when JDBC source metadata now exposes VARBINARY. Binary values map to STRING targets, with binary primary keys following the existing VARCHAR key conversion. Added a regression test that failed before the fix. - Fix invalid BE test fixtures: nullable ARRAY<VARIANT> elements, explicit predicate node kinds, Parquet predicate access paths with complete slot types, and independent named-timezone initialization. The array test also distinguishes SQL NULL from a Variant null value. - Align external/Python UDF regression expectations with the intended binary-safe and civil-time contracts. Binary materialization into OLAP uses explicit representations, and binary comparison fixtures explicitly choose text semantics. Retain result checks and V2 profile invariants across scanner/min-max/lazy switches. Local validation passed: 698 related BE tests, 378 FE tests, FE Checkstyle, clang-format 16 for all 74 C/C++ files touched by the PR, and syntax parsing for all 12 updated Groovy suites. The INT96 writer test also passes in isolation. The three unmuted FE failures from the previous CI run passed locally without relaxing their timeouts. The coverage build failed while starting an incompatible Node binary; the current TeamCity build configuration already uses the glibc-217 distribution. No shared CI configuration was changed as part of this follow-up. Full external regression requires the new CI run; local validation does not establish that every pipeline is green. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
