jacktengg commented on code in PR #67697:
URL: https://github.com/apache/doris/pull/67697#discussion_r4001641713
##########
be/src/exprs/vcast_expr.cpp:
##########
@@ -130,13 +130,14 @@ Status VCastExpr::execute_column_impl(VExprContext*
context, const Block* block,
return Status::OK();
}
-bool cast_error_code(Status& st) {
- //There may be more error codes that need to be captured by try cast in
the future.
- if (st.is<ErrorCode::INVALID_ARGUMENT>()) {
- return true;
- } else {
- return false;
- }
+bool cast_error_code(const Status& st) {
+ // Value conversion failures use INVALID_ARGUMENT (parsing, numeric/date
range checks,
+ // JSONB and complex elements) or ARITHMETIC_OVERFLOW_ERRROR (decimal
conversions).
+ // Keep execution failures such as allocation errors, invalid column
shapes and corruption
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
