yx-keith opened a new pull request, #67999:
URL: https://github.com/apache/doris/pull/67999
The MergedProfile parser reads every PlanInfo line and counter an operator
reports, but three defects lose or corrupt part of it, and the rest is thrown
away before the graph IR is built.
- A parenthesised table name loses its closing parenthesis:
table_name=item(item) becomes "item(item". TABLE_NAME_RE excluded "," and ")"
but not "(", so the greedy match ran past the opening parenthesis. The name is
shown in the operator details and used by the graph search.
- Counter keys could not contain a space, so every counter nested under a
parent failed to match and the whole RuntimeFilterInfo subtree was dropped.
Nested counters are now kept, keyed "parent/child" by indentation.
- PLAN_INFO_WHITELIST omitted PREDICATES, tablets, pushAggOp,
PREAGGREGATION, TOPN OPT and projections, and a line carrying two pairs
("TABLE: t, PREAGGREGATION: ON") leaked the second pair into the first value.
On the captured TPC-DS query 41 scan, the "Plan information" section of the
operator details goes from three rows, one of them wrong, to nine correct rows,
including the predicates and the tablets read.
Each node also keeps all its counters now, and two derived fields turn text
into numbers: planFacts (estimated rows, partitions and tablets selected out of
total, pushAggOp, preAggregation, predicates) and runtimeFilters (input,
filtered and always-true rows per filter). Nothing renders them yet; they are
the input for the diagnostics that follow. The rendered metrics are unchanged.
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
