github-actions[bot] commented on code in PR #68008:
URL: https://github.com/apache/doris/pull/68008#discussion_r4013844973
##########
fe/fe-connector/fe-connector-jdbc/src/main/java/org/apache/doris/connector/jdbc/client/JdbcMySQLConnectorClient.java:
##########
@@ -93,9 +93,11 @@ static boolean isDorisCompatibleVersionComment(String
versionComment) {
return false;
}
String lowerVersionComment = versionComment.toLowerCase(Locale.ROOT);
+ // Enterprise releases can omit the optional "(Cloud Mode)" suffix.
return lowerVersionComment.contains("doris")
|| lowerVersionComment.contains("selectdb")
|| lowerVersionComment.contains("velodb")
+ || lowerVersionComment.contains("enterprise version
enterprise-")
Review Comment:
The new disjunct is currently untested: both `JdbcMySQLClientTest` and
`JdbcMySQLConnectorClientTest` use an enterprise string that still contains
`(Cloud Mode)`, so they already return true through the old `enterprise version
&& cloud mode` branch. Removing or misspelling this line would therefore leave
both suites green and restore the reported no-suffix type-mapping failure.
Please add the exact no-suffix value (for example, `enterprise version
enterprise-4.0.5-rc01-0724569463d`) as a positive case in both test classes,
while retaining the existing cloud-mode case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
