morningman commented on PR #67966:
URL: https://github.com/apache/doris/pull/67966#issuecomment-5680145374
<!-- doris-repo-review:v1:begin -->
### Local pipeline review — ✅ PASS
```yaml
schema: doris-repo-review/v1
status: PASS
pr: apache/doris#67966
commit: 2425c004509a39820c99c24d11c1daf4d8f82d37
base: 17ac3d9275f8b7384c976d9bf8a5cc07512602b2
reviewed_at: 2026-09-15T20:27+08:00
reviewer: morningman
model: claude-opus-5
effort: max
findings: {blocker: 0, major: 0, minor: 1, nit: 5}
rounds: 1
converged: true
```
**Notes for maintainers**
-
`fe/fe-core/src/main/java/org/apache/doris/arrowflight/DorisFlightSqlProducer.java:311-325`
— residual Minor: a
non-deferred query that ran on the backends and whose `GetFlightInfo` then
fails at the Arrow schema fetch is still
not cancelled (`FlightSqlConnectProcessor.close()` runs before the catch,
which cancels deferred executors only), so
the BE keeps it until `execution_timeout + 5 s`. Same consequence class as
the earlier cancel-on-refusal fix; not a
regression against the base.
- Verified read-only from sources on both sides: `executor.cancel` after
`Coordinator.close` releases nothing twice and
throws nothing (QueueToken.cancel on a completed future is a no-op;
scan-node stop is idempotent; the BE answers a
cancel for a finished query with one WARNING). No build, unit test or
cluster run by the reviewer; the author's
131-case run and checkstyle result are taken from the handoff.
- The statement-loop reorder (audit before the break) is shared by both
protocols; the MySQL adapter's
`finishStatement` always returns true, so the MySQL audit order is
unchanged.
<sub>Reviewed locally with the `doris-repo-review` pipeline. Repository
policy may accept this receipt for the matching commit; it is not a human
Apache approval.</sub>
<!-- doris-repo-review:v1:end -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
