airborne12 commented on code in PR #67538:
URL: https://github.com/apache/doris/pull/67538#discussion_r4024846753
##########
be/src/exprs/function/like.cpp:
##########
@@ -1107,6 +1114,68 @@ Status FunctionRegexpLike::open(FunctionContext* context,
return Status::OK();
}
+// R8 (unity build): file-scope helpers use a namespace private to this file.
+namespace like_gram_index_detail {
+
+// A declined index leaves the rows to the predicate; the scan decides every
other index status.
+Status dispatch_query(bool is_like, const std::string& pattern,
segment_v2::IndexIterator* iter,
+ const IndexFieldNameAndTypePair& data_type_with_name,
uint32_t num_rows,
+ segment_v2::InvertedIndexResultBitmap* bitmap_result) {
+ segment_v2::InvertedIndexParam param;
+ param.column_name = data_type_with_name.first;
+ param.column_type = data_type_with_name.second;
+ param.query_value = Field::create_field<TYPE_STRING>(pattern);
+ param.query_type = is_like ?
segment_v2::InvertedIndexQueryType::LIKE_GRAM_QUERY
+ :
segment_v2::InvertedIndexQueryType::REGEXP_GRAM_QUERY;
+ param.num_rows = num_rows;
+ param.roaring = std::make_shared<roaring::Roaring>();
+
+ Status query_status = iter->read_from_index(¶m);
+ if (!query_status.ok()) {
+ if (query_status.is<ErrorCode::INVERTED_INDEX_EVALUATE_SKIPPED>() ||
+ query_status.is<ErrorCode::INVERTED_INDEX_NOT_SUPPORTED>()) {
+ return Status::OK();
+ }
+ return query_status;
+ }
+
+ segment_v2::InvertedIndexResultBitmap result(param.roaring, nullptr);
+ result.set_approximate(true);
+ *bitmap_result = result;
+ return Status::OK();
+}
+
+} // namespace like_gram_index_detail
+
+Status FunctionLikeBase::evaluate_gram_index(
+ GramCompileKind kind, const ColumnsWithTypeAndName& arguments,
+ const std::vector<IndexFieldNameAndTypePair>& data_type_with_names,
+ std::vector<segment_v2::IndexIterator*> iterators, uint32_t num_rows,
+ segment_v2::InvertedIndexResultBitmap& bitmap_result) const {
+ const bool is_like = (kind == GramCompileKind::LIKE);
+ if (!config::enable_gram_index_regexp) {
+ return Status::OK();
+ }
+ // VExpr binds whatever children it finds -- one entry per indexed column,
one per literal
+ // -- so the shape reaching here is not guaranteed. Answer only the shape
this compiler
+ // understands: a single indexed column and a single constant pattern.
`LIKE ... ESCAPE`
+ // arrives with a second literal and would otherwise be compiled with the
default escaping,
+ // which is not what the query asked for.
+ if (iterators.size() != 1 || data_type_with_names.size() != 1 ||
arguments.size() != 1 ||
Review Comment:
Yes, known as an issue, but no user would intend to use 'abc' LIKE
pattern_col
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
