github-actions[bot] commented on code in PR #67673:
URL: https://github.com/apache/doris/pull/67673#discussion_r4025730344
##########
be/src/exprs/aggregate/aggregate_function_ai_agg.h:
##########
@@ -68,20 +69,20 @@ class AggregateFunctionAIAggData {
}
}
- void write(BufferWritable& buf) const {
+ void write(BufferWritable& buf, int be_exec_version) const {
buf.write_binary(data);
buf.write_binary(inited);
buf.write_binary(_task);
- _ai_config.serialize(buf);
+ _ai_config.serialize(buf, be_exec_version >=
SUPPORT_AI_AGG_EFFORT_VERSION);
Review Comment:
[P2] Do not silently discard effort in version-14 partial states. Version 14
is still a supported mutable `be_exec_version`, and `AI_AGG` supports two-phase
plans. In a LOCAL/partial stage, `prepare()` loads the configured effort, but
this serialization omits it; the GLOBAL stage then rebuilds the adapter with an
empty effort and sends a different request. The equivalent one-phase plan never
serializes the state and keeps the effort, so behavior depends on plan shape.
Please either reject `AI_AGG` resources with effort when `be_exec_version <
15`, or preserve the setting outside the legacy state format, and cover the
distributed v14 path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
