morningman commented on code in PR #16388:
URL: https://github.com/apache/doris/pull/16388#discussion_r1097485966
##########
be/src/vec/exec/format/parquet/vparquet_page_index.h:
##########
@@ -33,7 +33,7 @@ class PageIndex {
Status collect_skipped_page_range(tparquet::ColumnIndex* column_index,
ColumnValueRangeType& col_val_range,
const FieldSchema* col_schema,
- std::vector<int>& skipped_ranges);
+ std::vector<int>& skipped_ranges, const
cctz::time_zone& utc);
Review Comment:
```suggestion
std::vector<int>& skipped_ranges,
const cctz::time_zone& tz);
```
##########
be/src/vec/exec/format/parquet/vparquet_page_index.cpp:
##########
@@ -40,15 +40,17 @@ Status
PageIndex::create_skipped_row_range(tparquet::OffsetIndex& offset_index,
Status PageIndex::collect_skipped_page_range(tparquet::ColumnIndex*
column_index,
ColumnValueRangeType&
col_val_range,
const FieldSchema* col_schema,
- std::vector<int>& skipped_ranges)
{
+ std::vector<int>& skipped_ranges,
+ const cctz::time_zone& utc) {
Review Comment:
```suggestion
const cctz::time_zone& tz) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
