github-actions[bot] commented on code in PR #68024: URL: https://github.com/apache/doris/pull/68024#discussion_r4027052577
########## regression-test/data/external_table_p0/paimon/paimon_timestamp_types.out: ########## @@ -5,6 +5,31 @@ -- !c2 -- 1 2024-01-02T10:04:05.100 2024-01-02T10:04:05.120 2024-01-02T10:04:05.123 2024-01-02T10:04:05.123400 2024-01-02T10:04:05.123450 2024-01-02T10:04:05.123456 2024-01-02T10:04:05.123456 2024-01-02T10:04:05.123456 2024-01-02T10:04:05.123456 2024-01-02T10:04:05.100 2024-01-02T10:04:05.120 2024-01-02T10:04:05.123 2024-01-02T10:04:05.123400 2024-01-02T10:04:05.123450 2024-01-02T10:04:05.123456 2024-01-02T10:04:05.123456 2024-01-02T10:04:05.123456 2024-01-02T10:04:05.123456 +-- !ts9_eq_orc -- +1 +1 Review Comment: The fixture and both unfiltered scans contain exactly one `id = 1`, so accepting two rows here (and for `<=`/`IN`) makes this regression preserve an ORC row-multiplication bug. A predicate cannot create a second source row. Please fix the filtered ORC path and regenerate these blocks with exactly one row; do not mask it with `DISTINCT`, which would prevent the test from detecting the duplication. ########## regression-test/data/external_table_p0/paimon/paimon_timestamp_types.out: ########## @@ -53,6 +78,27 @@ -- !c2 -- 1 2024-01-02T10:04:05.100 2024-01-02T10:04:05.120 2024-01-02T10:04:05.123 2024-01-02T10:04:05.123400 2024-01-02T10:04:05.123450 2024-01-02T10:04:05.123456 2024-01-02T10:04:05.123456 2024-01-02T10:04:05.123456 2024-01-02T10:04:05.123456 2024-01-02T10:04:05.100 2024-01-02T10:04:05.120 2024-01-02T10:04:05.123 2024-01-02T10:04:05.123400 2024-01-02T10:04:05.123450 2024-01-02T10:04:05.123456 2024-01-02T10:04:05.123456 2024-01-02T10:04:05.123456 2024-01-02T10:04:05.123456 +-- !ts9_eq_orc -- Review Comment: The same ORC row is exposed as `.123456` under JNI but `.123457` under the native reader, so this empty native equality block contradicts the truncation contract used by `PaimonPredicateConverter` and makes identical SQL return different rows when `force_jni_scanner` changes. Please establish one precision-reduction contract, align both scanner paths to it, and regenerate the snapshots so they produce the same row set. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
