github-actions[bot] commented on code in PR #68100:
URL: https://github.com/apache/doris/pull/68100#discussion_r4032667117
##########
cloud/src/meta-service/meta_service.cpp:
##########
@@ -4679,14 +4669,25 @@ void
MetaServiceImpl::get_delete_bitmap(google::protobuf::RpcController* control
// FIXME: Don't expose the implementation details of
splitting large value.
// merge splitted large values (>90*1000)
if (ver != last_ver || seg_id != last_seg_id) {
+ auto key = meta_delete_bitmap_key(
+ {instance_id, tablet_id, rowset_ids[i], ver,
seg_id});
+ // A successful page is not progress if a retry will
reread the same
+ // bitmap. Reset the budget only when its logical
start moves forward.
+ if (key != bitmap_start_key) {
Review Comment:
[P2] Advance the retry checkpoint after a known-complete bitmap
The retry counter is reset only after a key from the next `(version,
segment)` is decoded. If A has already used its three retries and then a
successful page ends with a bitmap that is provably complete (for example, a
legacy unsuffixed value or a short final blob chunk), `retry` remains 3. A
`TXN_TOO_OLD` on the continuation read then bypasses the retry branch before B
is decoded, so B gets no internal budget and the caller may restart the whole
RPC. Please advance the checkpoint/budget when completion is locally known, and
add a regression with three A retries followed by an expiry on the first
continuation toward B.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
