hubgeter commented on code in PR #68124:
URL: https://github.com/apache/doris/pull/68124#discussion_r4034511649
##########
fe/fe-connector/fe-connector-iceberg/src/main/java/org/apache/doris/connector/iceberg/IcebergScanPlanProvider.java:
##########
@@ -549,7 +549,7 @@ public ConnectorSplitSource streamSplits(ConnectorSession
session, ConnectorTabl
int formatVersion = getFormatVersion(table);
List<String> orderedPartitionKeys =
IcebergPartitionUtils.getIdentityPartitionColumns(table);
ZoneId zone = resolveSessionZone(session);
- boolean partitioned = table.spec().isPartitioned();
+ boolean partitioned = IcebergPartitionUtils.hasPartitionedSpec(table);
Review Comment:
Added `streamSplitsKeepsOldSpecIdentityValuesAfterEvolvingToUnpartitioned`:
it drains `streamSplits` on an identity(p) table evolved to unpartitioned and
asserts the partition value, columns-from-path, spec id and partition JSON.
Verified it is mutation-sensitive for this gate — reverting only line 552 to
`table.spec().isPartitioned()` makes it fail (`expected: <{p=7}> but was:
<{}>`) while the other evolution tests stay green.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
