luwei16 commented on PR #68094:
URL: https://github.com/apache/doris/pull/68094#issuecomment-5718287689
Local review result: **PASS**.
Reviewed the exact three-dot diff from
`e85575e3ad60389259dfe267a90124e6299a230a` to
`4ab7dd41af8bb63038f89a85562a28e09c40dc96`, including the merge resolution and
compatibility with current master `b0f266a8ebc1a333f806831f5d2209f837fda5d5`.
- Goal and scope: the FE → MetaService → BE path now propagates and persists
all six row-binlog configuration fields for Cloud tablets, including row-binlog
companion tablets.
- Correctness and persistence: the protobuf addition is backward-compatible;
MetaService updates both legacy and versioned tablet metadata through the
existing transactional path; failures are propagated and full-config retries
are idempotent.
- Concurrency and lifecycle: Cloud writes occur under exclusive
`_meta_lock`; all three reachable readers use a shared-lock value snapshot. No
recursive locking, lock-order inversion, or newly reachable unprotected copy
was found. The previous BinlogConfig data-race finding is fixed on this head.
- Compatibility and performance: the merge commit preserved both this PR’s
tests and upstream tests. A synthetic merge with current master is
conflict-free and the overlapping master changes are semantically unrelated.
The change adds only metadata-update work and lock-protected snapshot reads,
with no material hot-path regression identified.
- Tests and CI: FE, BE, and Cloud tests cover request fanout/all six fields,
MetaService persistence, BE refresh, and lock participation. Current Compile,
FE UT, BE UT, Cloud UT, style, regression, and performance checks passed. The
separate FE coverage failure is a Maven-download network failure before
`build.sh --fe` started.
- Attribution: temporary-partition coverage, ADD PARTITION versus ALTER,
concurrent ALTER ordering, and cross-batch partial success are pre-existing
orchestration behavior in unchanged code and are not findings introduced by
this PR.
Findings: Blocker 0, Major 0, Minor 0, Nit 0. The review converged in one
round. This was a read-only review; no local build or test was run.
<!-- doris-repo-review:v1:begin -->
```yaml
schema: doris-repo-review/v1
status: PASS
pr: apache/doris#68094
commit: 4ab7dd41af8bb63038f89a85562a28e09c40dc96
base: e85575e3ad60389259dfe267a90124e6299a230a
reviewed_at: 2026-09-18T01:05:58+08:00
reviewer: luwei16
model: gpt-5.6-sol
effort: xhigh
findings: {blocker: 0, major: 0, minor: 0, nit: 0}
rounds: 1
converged: true
```
<!-- doris-repo-review:v1:end -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
