morningman commented on PR #68117: URL: https://github.com/apache/doris/pull/68117#issuecomment-5725428777
Addressed the three round-3 findings in 41567d7e050 (all three were introduced by this PR, so they are fixed here rather than deferred): - `s3_uri.cpp`: `?` and `#` stay literal in ABFS/WASB object paths (ADLSLocation / Hadoop `Path` contract); S3 and HTTP(S) keep stripping. - `s3_util.cpp`: the OneLake fence checks the DNS host (no port, no trailing dot, case-folded). - `s3_util.cpp`: `-secondary` on official Azure hosts folds to the primary account for both the endpoint identity and the credential account check; HTTP(S) transport matching stays exact. Unit coverage: `S3URITest.QueryAndFragmentAreLiteralOnlyInAdlsPaths`, `S3ClientFactoryTest.OneLakeFenceIgnoresPortAndDnsRootDot`, `AllowsDocumentedAzureSecondaryEndpoints`, `SecondaryFoldingKeepsOtherAccountsApart`; `S3URITest.*` and `S3ClientFactoryTest.*` pass locally. FileFactory coverage for the literal `?`/`#` names lands with BE-2, which owns `file_factory.cpp`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
