github-actions[bot] commented on code in PR #67426:
URL: https://github.com/apache/doris/pull/67426#discussion_r4045541701
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/physical/RuntimeFilter.java:
##########
@@ -218,6 +218,11 @@ public boolean canPrunePartitions() {
return !partitionMonotonicity.isEmpty();
}
+ /** Whether this filter can eliminate complete scan ranges independently
of row-level selectivity. */
+ public boolean canPruneScanRanges() {
+ return canPruneBuckets() || canPrunePartitions();
Review Comment:
`canPruneScanRanges()` treats any non-empty partition monotonicity map as a
scan-range capability, but `OlapScanNode.hasRfDrivingPartitionPruning()`
suppresses partition-boundary serialization when fewer than two partitions are
selected. A non-selective partition-only RF on a scan reduced to one partition
is therefore retained without any range-pruning benefit and can still
wait/build normally. Please align this exemption with the downstream
eligibility (or otherwise require an actually pruning-capable target) and add a
one-selected-partition regression.
##########
regression-test/suites/query_p0/runtime_filter/rf_partition_pruning.groovy:
##########
@@ -24,12 +24,10 @@ import org.apache.doris.regression.action.ProfileAction
// sessions, so heavy parallel traffic could evict our profile before the
// poller finds it. Running serially keeps the assertions deterministic.
suite("rf_partition_pruning", "nonConcurrent") {
- // Disable the legacy RuntimeFilterPruner: it strips RFs whose
effectiveness
- // cannot be statistically verified, and the small INSERT-only tables in
- // this suite have no analyzed column stats, so the pruner would otherwise
Review Comment:
This setup enables the pruner but leaves
`enable_runtime_filter_partition_prune` at the fuzzy-session random value; the
first `assertRfPruningSessionSettings` (line 154) requires it to be true, and
the explicit assignment appears only at line 359. With
`use_fuzzy_session_variable=true`, the suite can fail nondeterministically
before its intended setup. Please set
`enable_runtime_filter_partition_prune=true` alongside the other suite-level
flags.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
