morningman commented on code in PR #16486:
URL: https://github.com/apache/doris/pull/16486#discussion_r1098714693
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/external/HMSExternalTable.java:
##########
@@ -294,6 +294,7 @@ public Partition getPartition(List<String> partitionValues)
{
@Override
public List<Column> initSchema() {
+ makeSureInitialized();
Review Comment:
Why need this?
##########
fe/fe-core/src/main/java/org/apache/doris/statistics/HiveAnalysisTask.java:
##########
@@ -85,7 +86,7 @@ protected void getColumnStatsByMeta() throws Exception {
Map<String, String> parameters =
table.getRemoteTable().getParameters();
// Collect table level row count, null number and timestamp.
setParameterData(parameters, params);
- params.put("id", String.valueOf(tbl.getId()) + "-" +
String.valueOf(col.getName()));
+ params.put("id", String.valueOf(tbl.getId()) + "--1-" + col.getName());
Review Comment:
I think we should extract a method to do this, currently, it is very error
prone
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
