eldenmoon commented on PR #68198:
URL: https://github.com/apache/doris/pull/68198#issuecomment-5747570456
<!-- doris-repo-review:v1:begin -->
### Local pipeline review — ✅ PASS
```yaml
schema: doris-repo-review/v1
status: PASS
pr: apache/doris#68198
commit: 56c2d553e6864c95c4f3a12180ad5ef5990a9e28
base: 934233d8160e8bdfeb9f511f4453b36231880049
reviewed_at: 2026-09-20T12:16+08:00
reviewer: eldenmoon
model: gpt-6-astra
effort: xhigh
findings: {blocker: 0, major: 0, minor: 0, nit: 0}
rounds: 1
converged: true
```
**Notes for maintainers**
- Static source review only: all 66 changed files covered by three qualified
reviewers, with independent lead verification; no builds, tests, cluster,
performance, or live rolling-upgrade/downgrade validation was run.
- `be/src/storage/segment/segment.cpp:962` and
`be/src/service/point_query_executor.cpp:606` — missing physical columns retain
requested-column defaults; point-query schema sourcing predates this PR.
Existing review threads were not duplicated.
- `be/src/storage/rowset/rowset_meta.cpp:251` and
`be/src/storage/segment/variant/variant_compaction_paths.h:32` — the moved
VARIANT layout was already nonpersistent; local/cloud and horizontal/vertical
reader/writer handoffs were traced. No new on-disk or FE/BE wire-format
incompatibility was found.
- `be/CMakeLists.txt:206` — checked-in NestedGroup routing was reviewed, but
the out-of-tree feature module was not; the legacy V1/V2 compaction fixture was
inspected but not executed.
- `be/test/storage/compaction/segcompaction_test.cpp:391` — the existing
sleep-based test-flakiness discussion (discussion_r4046293607) remains a known
limitation, not a newly counted finding.
<sub>Reviewed locally with the `doris-repo-review` pipeline. Repository
policy may accept this receipt for the matching commit; it is not a human
Apache approval.</sub>
<!-- doris-repo-review:v1:end -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
