morningman commented on PR #68266:
URL: https://github.com/apache/doris/pull/68266#issuecomment-5749482577
<!-- doris-repo-review:v1:begin -->
### Local pipeline review — ✅ PASS
```yaml
schema: doris-repo-review/v1
status: PASS
pr: apache/doris#68266
commit: 3877e16b32d1d9df3fbc124b172c90ada7c007cd
base: 69b3cb16873791fd9f63a59062c0591c61e7a4f8
reviewed_at: 2026-09-20T19:22+08:00
reviewer: morningman
model: claude-opus-5[1m]
effort: max
findings: {blocker: 0, major: 0, minor: 0, nit: 1}
rounds: 1
converged: true
```
**Notes for maintainers**
- Only finding is a Nit:
`be/test/exec/schema_scanner/schema_processlist_scanner_test.cpp:123` —
`fill_block_refuses_a_row_of_the_wrong_width` asserts a branch
`_fill_block_impl` can never hit in production (`start()` always fits every row
to 16 wide first). Optional: drop it or reframe it as asserting the post-fit
width invariant.
- Compatibility confirmed safe for the single-step upgrade this PR targets:
the audit stream-load is name-mapped
(`fe/.../plugin/audit/AuditStreamLoader.java:86`), so the `protocol` column's
physical position on an upgraded `audit_log` does not affect load correctness;
`/rest/v1/session/all` merges other FEs' rows by column-name key
(`fe/.../httpv2/controller/SessionController.java:111`), so an old FE's row
just renders an empty Protocol.
- Heads-up for future processlist columns: FE
`ShowProcessListCommand.fitToColumns` pads/cuts only at the end, while the BE
scanner also inserts an empty TraceId at index 11 for a 14-column row. Harmless
now (a 14-col FE predates #51400, unreachable in a supported upgrade), but the
two fit paths will diverge again if a column is ever inserted before the tail.
<sub>Reviewed locally with the `doris-repo-review` pipeline. Repository
policy may accept this receipt for the matching commit; it is not a human
Apache approval.</sub>
<!-- doris-repo-review:v1:end -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
