github-actions[bot] commented on code in PR #16463:
URL: https://github.com/apache/doris/pull/16463#discussion_r1099647672
##########
be/src/pipeline/exec/exchange_sink_buffer.cpp:
##########
@@ -155,58 +160,137 @@ Status ExchangeSinkBuffer::add_block(TransmitInfo&&
request) {
return Status::OK();
}
+Status ExchangeSinkBuffer::add_block(BroadcastTransmitInfo&& request) {
+ if (_is_finishing) {
+ return Status::OK();
+ }
+ TUniqueId ins_id = request.channel->_fragment_instance_id;
+ bool send_now = false;
+ request.block_holder->ref();
+ {
+ std::unique_lock<std::mutex>
lock(*_instance_to_package_queue_mutex[ins_id.lo]);
+ // Do not have in process rpc, directly send
+ if (_instance_to_sending_by_pipeline[ins_id.lo]) {
+ send_now = true;
+ _instance_to_sending_by_pipeline[ins_id.lo] = false;
+ }
+
_instance_to_broadcast_package_queue[ins_id.lo].emplace(std::move(request));
Review Comment:
warning: std::move of the variable 'request' of the trivially-copyable type
'doris::pipeline::BroadcastTransmitInfo' has no effect; remove std::move()
[performance-move-const-arg]
```suggestion
_instance_to_broadcast_package_queue[ins_id.lo].emplace(request);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
