OIiveirra commented on code in PR #68161:
URL: https://github.com/apache/doris/pull/68161#discussion_r4057106865
##########
be/src/format/column_type_convert.h:
##########
@@ -152,6 +162,37 @@ class ConsistentConverter : public ColumnTypeConverter {
bool is_consistent() override { return true; }
};
+class DateTimeV2PrecisionConverter : public ColumnTypeConverter {
+public:
+ explicit DateTimeV2PrecisionConverter(UInt32 to_scale) :
_to_scale(to_scale) {}
+
+ // NOLINTNEXTLINE(readability-make-member-function-const): base virtual
method is non-const.
+ Status convert(ColumnPtr& src_col, MutableColumnPtr& dst_col) override {
+ using ColumnType = typename
PrimitiveTypeTraits<TYPE_DATETIMEV2>::ColumnType;
Review Comment:
Fixed in 7dd90e77e85. DateTimeV2PrecisionConverter now retains the source
primitive, dispatches through a primitive-specific template, and uses
ColumnTimeStampTz/TimestampTzValue for TYPE_TIMESTAMPTZ. The added BE
regression covers V1 TIMESTAMPTZ p6-to-p0 truncation without rounding.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
