xy720 commented on code in PR #16444: URL: https://github.com/apache/doris/pull/16444#discussion_r1099759491
########## fe/fe-core/src/main/java/org/apache/doris/analysis/StructLiteral.java: ########## @@ -0,0 +1,150 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.doris.analysis; + +import org.apache.doris.catalog.StructField; +import org.apache.doris.catalog.StructType; +import org.apache.doris.catalog.Type; +import org.apache.doris.common.AnalysisException; +import org.apache.doris.thrift.TExprNode; +import org.apache.doris.thrift.TExprNodeType; + +import org.apache.commons.lang.StringUtils; + +import java.io.DataInput; +import java.io.DataOutput; +import java.io.IOException; +import java.util.ArrayList; +import java.util.List; + +public class StructLiteral extends LiteralExpr { + // only for persist + public StructLiteral() { + type = new StructType(); + children = new ArrayList<>(); + } + + public StructLiteral(LiteralExpr... exprs) throws AnalysisException { + type = new StructType(); + children = new ArrayList<>(); + for (LiteralExpr expr : exprs) { + if (!type.supportSubType(expr.getType())) { + throw new AnalysisException("Invalid element type in STRUCT."); + } + ((StructType) type).addField(new StructField(expr.getType())); + children.add(expr); + } + } + + protected StructLiteral(StructLiteral other) { + super(other); + } + + @Override + protected String toSqlImpl() { + List<String> list = new ArrayList<>(children.size()); + children.forEach(v -> list.add(v.toSqlImpl())); + return "STRUCT(" + StringUtils.join(list, ", ") + ")"; + } + + @Override + public String toDigestImpl() { + List<String> list = new ArrayList<>(children.size()); + children.forEach(v -> list.add(v.toDigestImpl())); + return "STRUCT(" + StringUtils.join(list, ", ") + ")"; + } + + @Override + public String getStringValue() { + List<String> list = new ArrayList<>(children.size()); + children.forEach(v -> list.add(v.getStringValue())); + return "{" + StringUtils.join(list, ", ") + "}"; Review Comment: May be we should support '(' ')' only in insert stmt in future. For select stmt and other places, we keep using brace{}. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
