selectdb-robot opened a new pull request, #68319:
URL: https://github.com/apache/doris/pull/68319

   ### What problem does this PR solve?
   
   Related PR: #68021
   
   Backport #68021 to `branch-4.1` to prevent NGRAM Bloom Filter pruning from 
dropping matching rows when a LIKE pattern contains a backslash or uses a 
custom ESCAPE. Escape-free patterns remain eligible for the index.
   
   Cherry-picked from `2fe54ad3516e0638444f91f4581d1127bb48a411`.
   
   One conflict was resolved in `TabletReader::_init_conditions_param`: retain 
branch-4.1's `function_filters` loop and `is_like_predicate(pred)` check, and 
add `pred->can_do_bloom_filter(true)` to the existing index initialization 
guard. The other BE changes and the regression suite are unchanged from the 
original patch.
   
   ### Validation
   
   - `git diff --check` passed; no unresolved conflicts.
   - Verified the patches for `olap_scan_operator.cpp` and 
`like_column_predicate.h` match the original commit.
   - Verified `test_ngram_bloomfilter_index_like_escape.groovy` is identical to 
the original commit.
   - Confirmed branch-4.1 already has `LikeState::has_custom_escape`.
   - Compilation and runtime regression tests were not run in this session; CI 
validation remains pending.
   
   ### Release note
   
   Fix incorrect LIKE query results with NGRAM Bloom Filter indexes when the 
pattern contains an escape.
   
   ### Check List (For Author)
   
   - Test
       - [x] Regression test included from #68021 (not executed in this session)
       - [ ] Unit Test
       - [ ] Manual test
   - Behavior changed:
       - [x] Yes. Skip NGRAM Bloom Filter pruning for LIKE patterns that can 
carry an escape.
   - Does this need documentation?
       - [x] No.
   
   ### Check List (For Reviewer who merge this PR)
   
   - [ ] Confirm the release note
   - [ ] Confirm test cases
   - [ ] Confirm document
   - [ ] Add branch pick label
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to