github-actions[bot] commented on code in PR #68323:
URL: https://github.com/apache/doris/pull/68323#discussion_r4060488685
##########
gensrc/proto/segment_v2.proto:
##########
@@ -215,7 +215,7 @@ message ColumnMetaPB {
optional ColumnPathInfo column_path_info = 13;
// Extra type info to be compatible with tabet schema
- optional bytes default_value = 14; // ColumnMessage.default_value ?
+ // optional bytes default_value = 14; // ColumnMessage.default_value, this
field is useless, it is added by https://github.com/apache/doris/pull/24170/
Review Comment:
`ColumnMetaPB` is persisted in both V2 footers and V3 external metadata, and
the pre-change corpus contains tag 14 2,437 times. Turning the declaration into
a comment removes it from the descriptor, so a future field can legally reuse
14 and reinterpret old bytes. Please add `reserved 14;` (and reserve the old
name `"default_value"` as schema hygiene).
Please also add explicit old-writer/new-reader coverage for both V2-inline
and V3-external metadata, either with representative pre-change segments or
targeted raw-tag injection. Regenerating all 148 goldens removes the only
fixtures containing this tag, including non-empty and binary defaults. The
runtime removal itself is otherwise compatible because readers source
schema-evolution defaults from `TabletColumn`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
